Skip to content

app: Give the onboarding window a title bar so its buttons clear the content #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nortonandreev merged 1 commit into from
Oct 23, 2026
Merged

app: Give the onboarding window a title bar so its buttons clear the content #1878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions src/Capacitor.App/Views/Onboarding/OnboardingPaneView.axaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,26 @@
<Ellipse Width="900" Height="900" HorizontalAlignment="Center" VerticalAlignment="Center"
Fill="{StaticResource OnboardingBloomBrush}" IsHitTestVisible="False" />

<Grid RowDefinitions="44,*">
<!-- The title bar: close, minimize and zoom sit over its left end, and its empty space drags the
window. The page scrolls beneath it, never under the buttons; the rule shows once it has. -->
<Border x:Name="TitleBar" Background="Transparent" PointerPressed="OnChromePointerPressed">
<Border x:Name="TitleBarRule" Height="1" VerticalAlignment="Bottom" Opacity="0" IsHitTestVisible="False"
Background="{StaticResource OnboardingDividerBrush}">
<Border.Transitions>
<Transitions>
<DoubleTransition Property="Opacity" Duration="0:0:0.14" />
</Transitions>
</Border.Transitions>
</Border>
</Border>

<!-- The footer scrolls with the page, so its actions sit below everything the step says; on a short
step the viewport-high grid still pins it to the bottom. -->
<ScrollViewer x:Name="StepScroll" VerticalScrollBarVisibility="Auto" HorizontalScrollBarVisibility="Disabled">
<ScrollViewer x:Name="StepScroll" Grid.Row="1" VerticalScrollBarVisibility="Auto" HorizontalScrollBarVisibility="Disabled"
ScrollChanged="OnStepScrolled">
<Grid RowDefinitions="*,Auto" MinHeight="{Binding #StepScroll.Viewport.Height}">
<StackPanel MaxWidth="620" HorizontalAlignment="Stretch" Margin="32,60,32,24" Spacing="26">
<StackPanel MaxWidth="620" HorizontalAlignment="Stretch" Margin="32,16,32,24" Spacing="26">
<Grid ColumnDefinitions="*,Auto" Margin="0,0,0,-8">
<app:ProductWordmark HorizontalAlignment="Left" />
<Button Grid.Column="1" Classes="onboardingQuiet" Content="Finish later"
Expand Down Expand Up @@ -156,8 +171,6 @@
</Border>
</Grid>
</ScrollViewer>

<!-- The pane covers the window's own drag strip. -->
<Border Height="40" VerticalAlignment="Top" Background="Transparent" PointerPressed="OnChromePointerPressed" />
</Grid>
</Panel>
</UserControl>
2 changes: 2 additions & 0 deletions src/Capacitor.App/Views/Onboarding/OnboardingPaneView.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,7 @@ void OnStepChanged(object? sender, PropertyChangedEventArgs e) {
if (e.PropertyName == nameof(OnboardingViewModel.Current)) StepScroll.Offset = default;
}

void OnStepScrolled(object? sender, ScrollChangedEventArgs e) => TitleBarRule.Opacity = StepScroll.Offset.Y > 0 ? 1 : 0;

void OnChromePointerPressed(object? sender, PointerPressedEventArgs e) => WindowChrome.BeginDrag(this, e);
}
Loading