.github/workflows/test.yml: pin actions to commit SHAs #350
Merged
Conversation
…ff Go version The repo's CI policy now rejects unpinned GitHub Actions: any uses clause referring to a tag (vN) instead of a full-length commit SHA fails Set up job with "are not allowed in kubernetes/utils because all actions must be pinned to a full-length commit SHA." Pins all references to current major-version commits and standardizes the action versions across jobs: actions/checkout@93cb6ef # v5 actions/setup-go@4a36011 # v6 golangci/golangci-lint-action@55c2c14 # v6 Also bumps the apidiff job's Go version from 1.23.x to 1.25.x. The job installs golang.org/x/exp/cmd/apidiff@latest, which now requires Go 1.25.0 to build: golang.org/x/exp/cmd/apidiff@latest: golang.org/x/exp@v0.0.0-... requires go >= 1.25.0 (running go 1.23.12; GOTOOLCHAIN=local) The Go version used to build the apidiff tool is independent of the module's go directive, so 1.25.x for that one job is safe. Signed-off-by: Davanum Srinivas <davanum@gmail.com>
k8s-ci-robot
added
the
kind/cleanup
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins all references to current major-version commits and standardizes the action versions across jobs:
actions/checkout@93cb6ef # v5
actions/setup-go@4a36011 # v6
golangci/golangci-lint-action@55c2c14 # v6
Also bumps the apidiff job's Go version from 1.23.x to 1.25.x.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: