Remove duplicate bootstrap duration observation in taint removal path

[rawadhossain]

Description

cleanup: duplicate observation of node_readiness_bootstrap_duration_seconds in the bootstrap-only taint removal path.
Two consecutive observation blocks recording the same bootstrap completion event.

This is important because upcoming metrics, dashboards, and SLOs rely on this histogram for accurate calculations. Duplicate samples would skew those results.

Files changed

File	Change
internal/controller/nodereadinessrule_controller.go	Remove duplicate Block
internal/controller/nodereadinessrule_controller_test.go	Add regression test + histogramSampleCount helper

Type of Change

/kind bug

Testing

Added test to verify the histogram sample count increases by exactly one for a bootstrap completion event

• Ran:
  • make test
  • make lint

Checklist

• make test passes
• make lint passes

[netlify]

✅ Deploy Preview for node-readiness-controller canceled.

Name	Link
🔨 Latest commit	47a3593
🔍 Latest deploy log	https://app.netlify.com/projects/node-readiness-controller/deploys/6a47873bb227d700085d976b

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rawadhossain
Once this PR has been reviewed and has the lgtm label, please assign tallclair for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Hi @rawadhossain. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ajaysundark]

/ok-to-test

/cc @Karthik-K-N

[Karthik-K-N]

Thank you for catching this. If possible we can do small improvement in test from the readability and stability aspect apart from that LGTM. Thank you.

[Karthik-K-N]

I think it does not matter, wont the create ignore status?
Usually we create only with spec

[rawadhossain]

you're right. Removed the Status block, now node is created with spec only

[Karthik-K-N]

Usually Update() call should go inside a Eventually block to have some retry, How about something like this

    Eventually(func() error {
        if err := k8sClient.Get(ctx, types.NamespacedName{Name: nodeName}, node); err != nil {
            return err
        }
        node.Status.Conditions = []corev1.NodeCondition{
            {
                Type:               "Ready",
                Status:             corev1.ConditionTrue,
                LastTransitionTime: transitionTime,
            },
        }
        return k8sClient.Status().Update(ctx, node)
    }, "5s", "100ms").Should(Succeed())

[rawadhossain]

Thanks for pointing this out. Commiting the changes now.