Skip to content

WIP infra: Add Scale Test#284

Draft
vitorfloriano wants to merge 9 commits into
kubernetes-sigs:mainfrom
vitorfloriano:infra/add-scalability-test
Draft

WIP infra: Add Scale Test#284
vitorfloriano wants to merge 9 commits into
kubernetes-sigs:mainfrom
vitorfloriano:infra/add-scalability-test

Conversation

@vitorfloriano

Copy link
Copy Markdown
Contributor

This PR adds a scale test harness to NRC.

Supersedes #185

Benchmarking plan:

Key design choices:

Implementation details/Roadmap:

  • Add scripts for setting up the testing environment (installing kwokctl, creating a cluster with a specified kubeconfig, installing the NRR CRD) and cleanup (deleting the kubeconfig, deleting the cluster)
  • Add Ginkgo suite for installing the NRR CRs, starting the controller, simulating changes at scale with kwokctl scale and Stage CRD.
  • Scrape metrics with Prometheus native Kwok integration
  • Add parameters for tuning the test and controller (node count, rule count, qps, burst, max concurrency)

@kubernetes-prow

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2026
@netlify

netlify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploy Preview for node-readiness-controller canceled.

Name Link
🔨 Latest commit 4c64f75
🔍 Latest deploy log https://app.netlify.com/projects/node-readiness-controller/deploys/6a4729abb37d990008e82ded

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vitorfloriano
Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 27, 2026
@vitorfloriano

Copy link
Copy Markdown
Contributor Author

/cc @Karthik-K-N
/cc @ajaysundark
/cc @Priyankasaggu11929

@vitorfloriano vitorfloriano left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After much research, this is the initial work. I got a LGTM on the approach from Kwok's maintainer, so I believe I'm headed in the right direction. PTAL.

Comment thread hack/scale-test-setup.sh Outdated
Comment thread hack/scale-test-setup.sh Outdated
Comment thread hack/scale-test-setup.sh Outdated
This reverts commit bb2ebc2.

Let's pivot to ginkgo-first, as Karthik had suggested. Sorry for
any incoveniences.
We're just being a bit more flexible
to allow it to be used in other paths
inside the test dir (e.g. test/scale).
this feels a bit like a hack. needs more
work.
@vitorfloriano vitorfloriano force-pushed the infra/add-scalability-test branch from def2c53 to a70405f Compare July 2, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant