Skip to content

feat: expose DeleteOptions in envfuncs.DeleteNamespace - #537

Open
cartermckinnon wants to merge 1 commit into
kubernetes-sigs:mainfrom
cartermckinnon:main
Open

feat: expose DeleteOptions in envfuncs.DeleteNamespace#537
cartermckinnon wants to merge 1 commit into
kubernetes-sigs:mainfrom
cartermckinnon:main

Conversation

@cartermckinnon

@cartermckinnon cartermckinnon commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

I want to delete a test's namespace in the foreground, to ensure the namespace is not left Terminating after the test completes.

I've exposed the resources.DeleteOptions to make this possible using resources.WithDeletePropagation.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

envfuncs.DeleteNamespace now accepts resources.DeleteOptions.

Additional documentation e.g., Usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 4, 2025
@k8s-ci-robot

k8s-ci-robot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cartermckinnon
Once this PR has been reviewed and has the lgtm label, please assign cpanato for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 4, 2025
@cartermckinnon

cartermckinnon commented Dec 11, 2025

Copy link
Copy Markdown
Contributor Author

@harshanarayana can you take a look at this one?

@harshanarayana

harshanarayana commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2025
@cartermckinnon

cartermckinnon commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

@vladimirvivien are you still an approver here?

vladimirvivien
vladimirvivien reviewed Dec 13, 2025
View reviewed changes

@vladimirvivien vladimirvivien left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good @cartermckinnon . Since it is changing the signature, please add some tests.

vladimirvivien
vladimirvivien reviewed Dec 13, 2025
View reviewed changes
Comment thread pkg/envfuncs/ns_funcs.go
// namespace. It first searches for the ns in its context, if not found then
// attempt to retrieve it from the API server. Then deletes it.
func DeleteNamespace(name string) env.Func {
func DeleteNamespace(name string, opts ...resources.DeleteOption) env.Func {

@vladimirvivien vladimirvivien Dec 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be backward compatible. However, please add some tests.

@k8s-triage-robot

k8s-triage-robot commented Mar 13, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 13, 2026
@vladimirvivien

vladimirvivien commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

@cartermckinnon - PTAL at my last comment.

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 15, 2026
@k8s-triage-robot

k8s-triage-robot commented Jun 13, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2026
@k8s-triage-robot

k8s-triage-robot commented Jul 13, 2026

Copy link
Copy Markdown

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@kubernetes-prow kubernetes-prow Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladimirvivien vladimirvivien vladimirvivien left review comments
@harshanarayana harshanarayana Awaiting requested review from harshanarayana
@ShwethaKumbla ShwethaKumbla Awaiting requested review from ShwethaKumbla

Assignees

@harshanarayana harshanarayana

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cartermckinnon @k8s-ci-robot @harshanarayana @k8s-triage-robot @vladimirvivien