Repository navigation
Hide the selected-tab overline in unfocused windows [patch] - #165
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
ImGuiPaletteMapper mapped TabDimmedSelectedOverline to the same opaque Primary High as TabSelectedOverline, so every dock node's selected tab carried the focused-window accent line and nothing showed which window had focus. Give the dimmed overline an alpha of 0, as ImGui's stock styles do, and test across every built-in theme that only the focused selected tab has an overline. Fixes #164 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW25U4pSY6LX1PUqHvi
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164
What was wrong
ImGuiPaletteMappermappedTabDimmedSelectedOverlineandTabSelectedOverlineto the same colour, opaque Primary High. Neither slot had an alpha override. ImGui draws the dimmed slot on the selected tab of every unfocused window or dock node, so all 38 built-in themes drew the focused-window accent line on every node's selected tab, and nothing showed which window had focus.Change
TabDimmedSelectedOverlinenow has an alpha override of0finalphaOverrides. That matches stock ImGui, whereStyleColorsDark()gives this slot(0.5, 0.5, 0.5, 0.0).TabSelectedOverlinekeeps its opaque Primary High.Tests
MapTheme_OnlyTheFocusedSelectedTabHasAnOverline. It sits next to the The selected tab of a docked window blends into its tab bar while unselected tabs stand out: TabSelected == TitleBgActive and TabDimmedSelected == TitleBg in all 38 themes #161/Give the selected tab its own fill on the tab bar [patch] #163 tab checks and runs over every theme inThemeRegistry.AllThemes. It asserts that the focused overline is opaque, that the dimmed overline is transparent, and that the two differ. With the fix reverted it fails (Catppuccin Latte: an unfocused window's selected tab draws an overline); with the fix it passes.ThemeProvider.Test: 94/94 pass.Generated by Claude Code