Skip to content

Give the selected tab its own fill on the tab bar [patch] #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 2 commits into from
Nov 4, 2026
Merged

Give the selected tab its own fill on the tab bar [patch] #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac67480
Give the selected tab its own fill on the tab bar [patch]
claude Nov 3, 2026
6f886c1
Merge remote-tracking branch 'origin/main' into fix/161-selected-tab-…
claude Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ThemeProvider.ImGui/ImGuiPaletteMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,12 +87,14 @@ public IReadOnlyDictionary<ImGuiCol, Vector4> MapTheme(ISemanticTheme theme)
{ ImGuiCol.TreeLines, new(SemanticMeaning.Neutral, Priority.MediumHigh)},

{ ImGuiCol.Tab, new(SemanticMeaning.Neutral, Priority.Low)},
{ ImGuiCol.TabSelected, new(SemanticMeaning.Primary, Priority.VeryLow)},
{ ImGuiCol.TabHovered, new(SemanticMeaning.Primary, Priority.Low)},
// The tab bar is filled with the title bar's color, so the selected tab sits one step above it
// to read as the open tab, and hovering steps up once more.
{ ImGuiCol.TabSelected, new(SemanticMeaning.Primary, Priority.Low)},
{ ImGuiCol.TabHovered, new(SemanticMeaning.Primary, Priority.MediumLow)},
{ ImGuiCol.TabSelectedOverline, new(SemanticMeaning.Primary, Priority.High)},
// Tabs in an unfocused window drop to neutral so the focused window's tabs stand out.
{ ImGuiCol.TabDimmed, new(SemanticMeaning.Neutral, Priority.VeryLow)},
{ ImGuiCol.TabDimmedSelected, new(SemanticMeaning.Neutral, Priority.Low)},
{ ImGuiCol.TabDimmedSelected, new(SemanticMeaning.Neutral, Priority.MediumLow)},
{ ImGuiCol.TabDimmedSelectedOverline, new(SemanticMeaning.Primary, Priority.High)},

// Alternate elements spread across the full 20-82% non-neutral range for better contrast
Expand Down
24 changes: 24 additions & 0 deletions ThemeProvider.Test/ImGuiPaletteMapperTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,30 @@ public void MapTheme_AlternateRowDiffersFromFrame()
}
}

/// <summary>
/// ImGui fills a dock node's tab bar with TitleBgActive when focused and TitleBg otherwise, and draws
/// the selected tab with TabSelected or TabDimmedSelected. Each selected tab must differ from the bar
/// it sits on, or only the 1px overline shows which tab is open. Hovering must also read differently
/// from being selected.
/// </summary>
[TestMethod]
public void MapTheme_SelectedTabsDifferFromTheirTabBar()
{
ImGuiPaletteMapper mapper = new();

foreach (ThemeRegistry.ThemeInfo info in ThemeRegistry.AllThemes)
{
IReadOnlyDictionary<ImGuiCol, Vector4> palette = mapper.MapTheme(info.CreateInstance());

AssertDistinct(palette, ImGuiCol.TabSelected, ImGuiCol.TitleBgActive, info.Name);
AssertDistinct(palette, ImGuiCol.TabDimmedSelected, ImGuiCol.TitleBg, info.Name);
AssertDistinct(palette, ImGuiCol.TabHovered, ImGuiCol.TabSelected, info.Name);
}
}

private static void AssertDistinct(IReadOnlyDictionary<ImGuiCol, Vector4> palette, ImGuiCol first, ImGuiCol second, string themeName) =>
Assert.IsGreaterThan(1f / 255f, Vector4.Distance(palette[first], palette[second]), $"{themeName}: {first} is drawn in the {second} color");

private sealed class NoNeutralTheme : ISemanticTheme
{
public Dictionary<SemanticMeaning, Collection<Color>> SemanticMapping { get; } = new()
Expand Down
Loading