Repository navigation
Compare a SignificantNumber with a PreciseNumber through Equals [minor] - #144
Merged
Merged
Conversation
sig.Equals(precise) bound to the record struct's Equals(object), which boxed the PreciseNumber and returned false, while ==, CompareTo and precise.Equals(sig) all reported the values as equal. Add Equals(PreciseNumber) so both argument orders and == agree, and document that a boxed PreciseNumber passed to Equals(object) still compares unequal. Fixes #143 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5i3pXEZd4rgcVGix1
Move Equals(PreciseNumber) below the last CompareTo overload, which Sonar rule S4136 flagged after it landed between two of them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5i3pXEZd4rgcVGix1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sig.Equals(precise)bound to the record struct's synthesizedEquals(object). That boxed thePreciseNumber, failed theis SignificantNumbercheck, and returnedfalse, while==,CompareTo(object)andprecise.Equals(sig)all reported the values as equal.public bool Equals(PreciseNumber other) => Value.Equals(other);, sos.Equals(p),p.Equals(s)ands == pgive the same answer.PreciseNumberboxed asobjectand passed toEquals(object)still compares unequal, because a record struct'sEquals(object)can't be customised, even thoughCompareTo(object)returns 0.This adds public API, hence
[minor].Tests
EqualsPreciseNumber_AgreesInBothArgumentOrdersAndWithOperatorcovers equal values (including1.50vs1.5, zero and a negative) and unequal values in both orders, and checks the result against==andCompareTo(object).EqualsObject_BoxedPreciseNumber_IsFalseEvenWhenEqualpins the documented boxed case.s.Equals(p). With the fix, the whole suite passes locally (197/197, net10.0).Fixes #143
Generated by Claude Code