Repository navigation
Call the shared pipeline through ci.yml instead of a local dotnet.yml - #41
Open
matt-edmondson wants to merge 1 commit into
Open
matt-edmondson wants to merge 1 commit into
matt-edmondson wants to merge 1 commit into
Conversation
NoSleep carried its own copy of the .NET workflow, so it missed changes to ci-shared.yml and its profile Status depended on the generator's --fallback-workflow dotnet.yml flag. Replace it with the standard ci.yml (identical to FileDeduplicator's and SvnToGit's), point the Dependabot merge gate at the new workflow name "CI", and point the README build badge at ci.yml. Fixes #21 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW4SLyvTvUJUdcrUu7F
Collaborator
Author
|
Needed: add the Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21
What changed
.github/workflows/ci.yml, byte-for-byte the same as FileDeduplicator's and SvnToGit's. It callsktsu-dev/.github/.github/workflows/ci-shared.yml@releasewith the usual triggers, concurrency and caller permissions..github/workflows/dotnet.yml, NoSleep's local copy of the pipeline. Withci.ymlin place it would have run every build twice.dependabot-merge.ymlnow lists"CI"in itsworkflow_runlist, replacing".NET Workflow". The list matches on the workflow'sname:, so without this change a green Dependabot PR would never trigger the merge gate again.ci.yml.Verification
ci.ymlis identical to the one already running in FileDeduplicator and SvnToGit.ktsubuild profile readme --org ktsu-dev --only NoSleepshows a status without--fallback-workflow. That command reads the default branch, so it can only be checked after merge. This PR's own CI run is the first test of the new pipeline on NoSleep.Not changed
dependabot-merge.ymlstill calls the shared gate at@main, while FileDeduplicator uses@release. Moving it isn't part of this issue, so it's left for a separate change.Generated by Claude Code