Repository navigation
Add CompatibilitySuppressions.xml for the Polyfill 11.4.5 shim drift [patch] - #38
Merged
Merged
Conversation
…[patch] Polyfill 11.4.5 emits its DefaultInterpolatedStringHandler and ExperimentalAttribute shims with different nullable attributes on net9.0 and net10.0, so pack has failed package validation on main since Oct 14 and v1.1.1-pre.3 is still the latest release. The fix for #30 has never reached NuGet. Generated with -p:ApiCompatGenerateSuppressionFile=true: 9 entries (8 CP0014, 1 CP0015), all on Polyfill shim types and none on NoSleep's own API. Pack passes with the file and fails without it. Fixes #37 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW6AsrvoXnjisxocXeu
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polyfill 11.4.5 emits its
DefaultInterpolatedStringHandlerandExperimentalAttributeshims with different nullable attributes on net9.0 and net10.0. Since Oct 14 that has madedotnet packfail package validation onmain, so v1.1.1-pre.3 is still the latest release and the #30 fix has never shipped.This adds
NoSleep/CompatibilitySuppressions.xml, generated with-p:ApiCompatGenerateSuppressionFile=true. It has 9 entries (8 CP0014, 1 CP0015), all on Polyfill shim types. None is on NoSleep's own API. Sibling repos fixed the same failure the same way.Validation (SDK 10.0.403, Linux):
dotnet pack NoSleep/NoSleep.csproj -c Releasefails with the CP0014/CP0015 errors from the issue.Fixes #37
Generated by Claude Code