[matt-edmondson]

Fixes #174

What changed

WriteDefaultValueTo and PropertyTemplate used to skip the initialiser whenever DefaultValue was empty. They did this even with DefaultValueIsQuoted set, where empty raw text means the empty string "". Both now go through one private protected HasDefaultValue => DefaultValueIsQuoted || !string.IsNullOrEmpty(DefaultValue), so the following now render correctly:

• string separator = "" stays optional. Before, it became required, which gave CS1737 after an earlier optional parameter.
• public const string Empty = ""; keeps its value. Before, the missing value gave CS0145.
• Shorthand and braced properties keep = "";.

An empty default without quoting still writes no initialiser. The DefaultValue doc now explains the quoted case. The new member is private protected, so the public API does not change.

Tests

• Added six tests to TemplateTests, covering a parameter, a method with a trailing optional parameter, a const field, a shorthand property and a braced property. They also confirm that an unquoted empty default still writes nothing.
• With the fix reverted, five of the new tests fail. The unquoted guard test passes either way, as it should. With the fix, all 255 tests pass.
• A local Sonar run (.sonarlint/sonar-local.props) reports only the five existing S2699 findings in the test project.

---

Generated by Claude Code

[matt-edmondson]

I merged main into this branch to clear the conflict in TemplateBase.cs. I kept main's new Validate() and this PR's HasDefaultValue cref.

Update: the red CI described below is now fixed on main. #162 changed JoinWarnings so that an entry containing a line terminator is no longer trimmed. Main has since been merged into this branch, and at e240d7f Test passes on ubuntu, windows and macos. The patch I proposed below is no longer needed.

Original note

Test on ubuntu/windows/macos each failed the same 6 PragmaScope line-terminator tests that also failed on main at 589a81a. The cause was #167: JoinWarnings trimmed each entry before Begin checked for line terminators, so a trailing terminator was removed before it could be refused.

---

Generated by Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud