Repository navigation
Report an undeclared duplicate doc tag once [patch] - #172
Merged
matt-edmondson merged 1 commit intoNov 4, 2026
Merged
Conversation
DocComment.Validate ran the "does not match any declared" check for every copy of a tag, so two <param name="y"> entries for an undeclared y gave that message twice. Run it only on the first copy and leave the later copies to the "documented more than once" message. Fixes #171 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017vfJW5LkA4KtEKYNbjk5tz
|
matt-edmondson
deleted the
claude/issue-171-report-duplicate-undeclared-tag-once
branch
November 4, 2026 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171
Summary
DocComment.Validatechecked "does not match any declared parameter" for every copy of a tag. Two<param name="y">entries for an undeclaredygot that message twice, three copies got it three times. Its<returns>doc promises one message per problem.Changes
Checknow runs the "does not match" test only the first time it sees a name, whendocumented.Add(name)returns true. Later copies still get "documented more than once". The messages themselves are unchanged.Tests
ValidationReportsADuplicateUndeclaredTagOnce: threeytags against declaredxgive exactly one "does not match", two "more than once" and one "has no entry".ValidationReportsADuplicateUndeclaredTypeParameterTagOnce: the same case for<typeparam>.mainand pass with the fix. I checked this by revertingDocComment.csand running them again.Generated by Claude Code