Fix action approach walks being interrupted or shortened - #71
Open
taylorszz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes scripted action approach walks being incorrectly interrupted, shortened, or path-skipped before the associated NVC action begins.
Covers Issue #51
Changes
SkipToViewfrom interrupting walks during an action approach.GKActorwalk-to-animation handling so the approach walk is completed before starting the associated animation/action.Result
Action approach walks now complete as intended without being prematurely shortened or interrupted by trigger handling,
SkipToView, or frustum path optimization, while preserving the existing interruption behavior once the actual NVC action has started.