Skip to content

chore(deps): update coins-bip32 requirement from 0.16 to 0.17 in /bip0032 #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koushiro merged 5 commits into from
Oct 31, 2026
Merged

chore(deps): update coins-bip32 requirement from 0.16 to 0.17 in /bip0032 #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c075792
chore(deps): update coins-bip32 requirement in /bip0032
dependabot[bot] Oct 29, 2026
6ef7309
fix compilation
koushiro Oct 31, 2026
f979059
update benchmark results
koushiro Oct 31, 2026
ddf1697
bump MSRV to 1.87
koushiro Oct 31, 2026
146f0f8
bli: bump MSRV to 1.87
koushiro Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/bip0032.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ jobs:
check-msrv:
runs-on: ubuntu-latest
env:
MSRV: 1.85.0
MSRV: 1.87.0
steps:
- uses: actions/checkout@v7

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
check-msrv:
runs-on: ubuntu-latest
env:
MSRV: 1.85.0
MSRV: 1.87.0
steps:
- uses: actions/checkout@v7
- name: Setup MSRV
Expand Down
2 changes: 1 addition & 1 deletion bip0032/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ resolver = "3"

[workspace.package]
edition = "2024"
rust-version = "1.85.0"
rust-version = "1.87.0"
license = "Apache-2.0"
homepage = "https://github.com/koushiro/rust-bips"
repository = "https://github.com/koushiro/rust-bips"
Expand Down
2 changes: 1 addition & 1 deletion bip0032/benchmarks/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ publish = false
bip0032 = { path = "..", features = ["k256", "secp256k1"] }
bip32 = { version = "0.6", features = ["alloc"] }
bitcoin = "0.32"
coins-bip32 = "0.16"
coins-bip32 = "0.17"
const-hex = "1.12.0"
criterion = "0.8"
rand = "0.10"
Expand Down
72 changes: 36 additions & 36 deletions bip0032/benchmarks/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ cargo bench --bench keygen -- --quiet

```text
keygen/bitcoin (secp256k1)
time: [1.1091 µs 1.1597 µs 1.2225 µs]
time: [1.0487 µs 1.0551 µs 1.0642 µs]
keygen/coins-bip32 (k256::ecdsa)
time: [20.086 µs 20.860 µs 21.836 µs]
keygen/bip32 (k256) time: [442.38 ns 445.00 ns 448.04 ns]
time: [18.976 µs 19.010 µs 19.049 µs]
keygen/bip32 (k256) time: [429.29 ns 430.23 ns 431.22 ns]
keygen/bip32 (k256::ecdsa)
time: [20.448 µs 21.321 µs 22.818 µs]
keygen/bip0032 (k256) time: [476.96 ns 489.49 ns 509.86 ns]
time: [18.829 µs 18.966 µs 19.231 µs]
keygen/bip0032 (k256) time: [456.56 ns 458.03 ns 459.91 ns]
keygen/bip0032 (secp256k1)
time: [466.61 ns 471.15 ns 476.45 ns]
time: [453.60 ns 454.56 ns 455.67 ns]
```

## Derivation
Expand All @@ -32,15 +32,15 @@ cargo bench --bench derive -- --quiet

```text
derive/bitcoin (secp256k1)
time: [140.77 µs 141.73 µs 142.84 µs]
time: [137.03 µs 138.38 µs 140.63 µs]
derive/coins-bip32 (k256::ecdsa)
time: [100.26 µs 101.03 µs 101.93 µs]
derive/bip32 (k256) time: [157.51 µs 160.03 µs 162.90 µs]
time: [97.306 µs 98.216 µs 99.919 µs]
derive/bip32 (k256) time: [151.24 µs 151.49 µs 151.77 µs]
derive/bip32 (k256::ecdsa)
time: [101.90 µs 104.00 µs 107.86 µs]
derive/bip0032 (k256) time: [98.910 µs 102.03 µs 106.47 µs]
time: [95.802 µs 95.999 µs 96.262 µs]
derive/bip0032 (k256) time: [96.290 µs 96.740 µs 97.350 µs]
derive/bip0032 (secp256k1)
time: [189.29 µs 192.43 µs 196.19 µs]
time: [181.08 µs 181.57 µs 182.12 µs]
```

## Serialization
Expand All @@ -54,17 +54,17 @@ cargo bench --bench xprv_decode -- --quiet

```text
xprv_decode/bitcoin (secp256k1)
time: [9.9199 µs 10.080 µs 10.377 µs]
time: [9.8629 µs 9.9777 µs 10.197 µs]
xprv_decode/coins-bip32 (k256::ecdsa)
time: [23.738 µs 23.820 µs 23.910 µs]
time: [23.526 µs 23.581 µs 23.641 µs]
xprv_decode/bip32 (k256)
time: [5.4202 µs 5.4342 µs 5.4484 µs]
time: [5.4301 µs 5.4603 µs 5.5051 µs]
xprv_decode/bip32 (k256::ecdsa)
time: [24.022 µs 24.146 µs 24.282 µs]
time: [23.835 µs 23.942 µs 24.114 µs]
xprv_decode/bip0032 (k256)
time: [5.4571 µs 5.5057 µs 5.5926 µs]
time: [5.4656 µs 5.4840 µs 5.5038 µs]
xprv_decode/bip0032 (secp256k1)
time: [5.4505 µs 5.4667 µs 5.4837 µs]
time: [5.4477 µs 5.4622 µs 5.4776 µs]
```

### xprv encode
Expand All @@ -76,17 +76,17 @@ cargo bench --bench xprv_encode -- --quiet

```text
xprv_encode/bitcoin (secp256k1)
time: [9.5047 µs 9.5347 µs 9.5675 µs]
time: [9.4059 µs 9.4221 µs 9.4408 µs]
xprv_encode/coins-bip32 (k256::ecdsa)
time: [8.7005 µs 8.7392 µs 8.7860 µs]
time: [8.7630 µs 8.7923 µs 8.8286 µs]
xprv_encode/bip32 (k256)
time: [9.0248 µs 9.1062 µs 9.2230 µs]
time: [8.9820 µs 9.0774 µs 9.2691 µs]
xprv_encode/bip32 (k256::ecdsa)
time: [9.0370 µs 9.0594 µs 9.0864 µs]
time: [9.0192 µs 9.0603 µs 9.1247 µs]
xprv_encode/bip0032 (k256)
time: [8.9886 µs 9.0146 µs 9.0436 µs]
time: [8.9589 µs 8.9723 µs 8.9866 µs]
xprv_encode/bip0032 (secp256k1)
time: [9.0377 µs 9.2503 µs 9.5029 µs]
time: [8.9467 µs 8.9796 µs 9.0311 µs]
```

### xpub decode
Expand All @@ -98,17 +98,17 @@ cargo bench --bench xpub_decode -- --quiet

```text
xpub_decode/bitcoin (secp256k1)
time: [13.732 µs 14.425 µs 15.818 µs]
time: [13.529 µs 13.576 µs 13.632 µs]
xpub_decode/coins-bip32 (k256::ecdsa)
time: [10.130 µs 10.152 µs 10.173 µs]
time: [9.9580 µs 9.9850 µs 10.016 µs]
xpub_decode/bip32 (k256)
time: [10.487 µs 10.521 µs 10.561 µs]
time: [10.419 µs 10.549 µs 10.799 µs]
xpub_decode/bip32 (k256::ecdsa)
time: [10.500 µs 10.529 µs 10.564 µs]
time: [10.446 µs 10.477 µs 10.511 µs]
xpub_decode/bip0032 (k256)
time: [10.491 µs 10.517 µs 10.544 µs]
time: [10.466 µs 10.515 µs 10.572 µs]
xpub_decode/bip0032 (secp256k1)
time: [9.2711 µs 9.3670 µs 9.5555 µs]
time: [9.2570 µs 9.3233 µs 9.4144 µs]
```

### xpub encode
Expand All @@ -120,15 +120,15 @@ cargo bench --bench xpub_encode -- --quiet

```text
xpub_encode/bitcoin (secp256k1)
time: [9.5350 µs 9.5693 µs 9.6063 µs]
time: [9.3495 µs 9.3661 µs 9.3839 µs]
xpub_encode/coins-bip32 (k256::ecdsa)
time: [8.9610 µs 9.0024 µs 9.0534 µs]
time: [8.8644 µs 8.8956 µs 8.9323 µs]
xpub_encode/bip32 (k256)
time: [9.2538 µs 9.4143 µs 9.7080 µs]
time: [9.1113 µs 9.1304 µs 9.1514 µs]
xpub_encode/bip32 (k256::ecdsa)
time: [9.2394 µs 9.2678 µs 9.2980 µs]
time: [9.1492 µs 9.1841 µs 9.2267 µs]
xpub_encode/bip0032 (k256)
time: [9.2503 µs 9.2694 µs 9.2904 µs]
time: [9.1966 µs 9.2148 µs 9.2331 µs]
xpub_encode/bip0032 (secp256k1)
time: [9.2391 µs 9.3440 µs 9.5067 µs]
time: [9.1282 µs 9.1495 µs 9.1730 µs]
```
6 changes: 3 additions & 3 deletions bip0032/benchmarks/src/serialize/xprv_decode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,17 @@ fn bench_bitcoin(group: &mut BenchmarkGroup<'_>) {
}

fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
use coins_bip32::prelude::{Hint, MainnetEncoder, XKeyEncoder, XPriv};
use coins_bip32::prelude::{Hint, MAINNET, XPriv};

group.bench_function("coins-bip32 (k256::ecdsa)", |b| {
b.iter_batched(
|| {
let seed = random_seed();
let xprv = XPriv::root_from_seed(&seed, Some(Hint::Legacy)).unwrap();
MainnetEncoder::xpriv_to_base58(&xprv).unwrap()
xprv.to_base58()
},
|encoded| {
let xprv = MainnetEncoder::xpriv_from_base58(black_box(&encoded)).unwrap();
let xprv = XPriv::from_base58_with(black_box(&encoded), &[&MAINNET]).unwrap();
black_box(xprv);
},
BatchSize::SmallInput,
Expand Down
4 changes: 2 additions & 2 deletions bip0032/benchmarks/src/serialize/xprv_encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ fn bench_bitcoin(group: &mut BenchmarkGroup<'_>) {
}

fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
use coins_bip32::prelude::{Hint, MainnetEncoder, XKeyEncoder, XPriv};
use coins_bip32::prelude::{Hint, XPriv};

group.bench_function("coins-bip32 (k256::ecdsa)", |b| {
b.iter_batched(
Expand All @@ -34,7 +34,7 @@ fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
XPriv::root_from_seed(&seed, Some(Hint::Legacy)).unwrap()
},
|xprv| {
let encoded = MainnetEncoder::xpriv_to_base58(&xprv).unwrap();
let encoded = xprv.to_base58();
black_box(encoded);
},
BatchSize::SmallInput,
Expand Down
6 changes: 3 additions & 3 deletions bip0032/benchmarks/src/serialize/xpub_decode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,18 @@ fn bench_bitcoin(group: &mut BenchmarkGroup<'_>) {
}

fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
use coins_bip32::prelude::{Hint, MainnetEncoder, XKeyEncoder, XPriv};
use coins_bip32::prelude::{Hint, MAINNET, XPriv, XPub};

group.bench_function("coins-bip32 (k256::ecdsa)", |b| {
b.iter_batched(
|| {
let seed = random_seed();
let xprv = XPriv::root_from_seed(&seed, Some(Hint::Legacy)).unwrap();
let xpub = xprv.verify_key();
MainnetEncoder::xpub_to_base58(&xpub).unwrap()
xpub.to_base58()
},
|encoded| {
let xpub = MainnetEncoder::xpub_from_base58(black_box(&encoded)).unwrap();
let xpub = XPub::from_base58_with(black_box(&encoded), &[&MAINNET]).unwrap();
black_box(xpub);
},
BatchSize::SmallInput,
Expand Down
4 changes: 2 additions & 2 deletions bip0032/benchmarks/src/serialize/xpub_encode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ fn bench_bitcoin(group: &mut BenchmarkGroup<'_>) {
}

fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
use coins_bip32::prelude::{Hint, MainnetEncoder, XKeyEncoder, XPriv};
use coins_bip32::prelude::{Hint, XPriv};

group.bench_function("coins-bip32 (k256::ecdsa)", |b| {
b.iter_batched(
Expand All @@ -41,7 +41,7 @@ fn bench_coins_bip32(group: &mut BenchmarkGroup<'_>) {
xprv.verify_key()
},
|xpub| {
let encoded = MainnetEncoder::xpub_to_base58(&xpub).unwrap();
let encoded = xpub.to_base58();
black_box(encoded);
},
BatchSize::SmallInput,
Expand Down
2 changes: 1 addition & 1 deletion bli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "bli"
version = "0.0.1"
authors = ["koushiro <koushiro.cqx@gmail.com>"]
edition = "2024"
rust-version = "1.85.0"
rust-version = "1.87.0"
license = "Apache-2.0"
homepage = "https://github.com/koushiro/rust-bips"
repository = "https://github.com/koushiro/rust-bips"
Expand Down
Loading