Implement alias support. - #220
Open
willnationsdev wants to merge 4 commits into
Open
Conversation
Resolves issue kortina#139 by fixing ESLint indentation errors and resolves the broken build on master by updating dependencies and fixing type issues. ### Fixes - Fixed indentation in NoteParser.ts line 164 (ESLint error from kortina#139) - Fixed BacklinksTreeDataProvider.ts EventEmitter type to allow undefined for fire() call - Updated @types/node from v11 to v18 to fix Buffer type compatibility issues - Updated @types/glob from v7 to v8 and glob from v7 to v9 to fix minimatch compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #147.
This branch is currently built on top of #218 (which I accidentally rebased, so it included me as an editor of it).
I had to additionally apply some package vulnerability updates to remove the warnings I was getting when building the code.
The commit for the actual alias changes is isolated from everything else.
I then had to add an additional commit to properly make aliases/refs inside codeblocks be ignored (and to stop them from getting syntax highlighting).
Each of these could theoretically be their own separate PR, so let me know how you might want to merge it in. It's implemented exactly as was discussed in the issue albeit with one exception.
We mentioned at the end of the issue that we expected it to pick a specific alias if there were any conflicts, but I figured an arbitrary solution would be frustrating. Instead, it just uses VS Code's default behavior of showing a peek of all the conflicting definitions for the user to choose from. Just like it would with C# partial declarations or similar.