fix(bmp): correct bpp shift and prevent overflow - #69
Open
tachibana-shin wants to merge 1 commit into
Open
Conversation
- Correct bit shift to calculate bytes per pixel - Change tc to long to prevent integer overflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
bpp>>8→bpp>>3inbmp_clear_outside_crop_borderBug:
bytes_per_pixwas always 0, causing allmemset()calls in this function to be no-ops (writing 0 bytes). Color bitmap crop borders were never cleared to white.Root cause:
bppis bits per pixel (8 or 24, perwillus.h:517). Dividing by 256 (>>8) is wrong — should be dividing by 8 (>>3) to convert bits to bytes.Evidence:
willus.h:517):With bytes_per_pix=0, memset writes 0 bytes — color borders are never cleared.
4. Consistent with bmp_bytewidth (bmp.c:1410):
Same conversion: bpp 24 → 3 bytes, bpp 8 → 1 byte.
Before: bpp>>8: 8→0, 24→0 (always 0, wrong)
After: bpp>>3: 8→1, 24→3 (correct bytes per pixel)
This change is