Skip to content

fix: button-group replaced gap with background-clip (#DS-5112)#1691

Open
NikGurev wants to merge 5 commits into
mainfrom
bugfix/DS-5112
Open

fix: button-group replaced gap with background-clip (#DS-5112)#1691
NikGurev wants to merge 5 commits into
mainfrom
bugfix/DS-5112

Conversation

@NikGurev

@NikGurev NikGurev commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@NikGurev NikGurev self-assigned this Jul 3, 2026
@NikGurev NikGurev added the bug Something isn't working label Jul 3, 2026
@NikGurev NikGurev changed the title fix(button): replaced gap with background-clip (#DS-5112) fix: button-group replaced gap with background-clip (#DS-5112) Jul 3, 2026
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 07bf579):

https://koobiq-next--prs-1691-pc5qeex6.web.app

(expires Wed, 08 Jul 2026 14:35:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🚨 E2E tests failed

Review the report for details.


💡 Comment /approve-snapshots to approve snapshot changes.

@NikGurev

NikGurev commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

/approve-snapshots

@NikGurev NikGurev marked this pull request as ready for review July 3, 2026 11:30
@NikGurev NikGurev requested a review from lskramarov as a code owner July 3, 2026 11:30
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🔄 Updating snapshots.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

✅ Snapshots updated!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the kbq-button-group styling to remove the reliance on gap and instead achieve the intended visual separation/joins via border/background painting behavior, with the e2e example updated accordingly.

Changes:

  • Removed layout-gap-3xs usage from the button-group e2e example markup.
  • Updated button-group SCSS to use background-clip and border/pseudo-element techniques for button junction rendering (including a divider for filled contrast-fade groups).

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 3 comments.

File Description
packages/components/button/e2e.ts Removes external layout gap class from a button-group example to reflect the new styling approach.
packages/components/button/button-group.scss Replaces the previous gap approach with border/background-clip and divider pseudo-elements for filled button-group junctions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/components/button/button-group.scss
Comment thread packages/components/button/button-group.scss
Comment thread packages/components/button/button-group.scss Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants