fix(tree-select): add missing takeUntil to prevent subscription leaks (#DS-5143)#1688
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 7131e7e): https://koobiq-next--prs-1688-jgon8rt5.web.app (expires Tue, 07 Jul 2026 13:23:04 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
NikGurev
approved these changes
Jul 2, 2026
artembelik
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates KbqTreeSelect to ensure RxJS subscriptions created during component lifecycle are properly torn down, preventing potential memory leaks and post-destroy side effects.
Changes:
- Added
takeUntilDestroyed(this.destroyRef)toselectionModel.changedsubscriptions (including the delayed overlay positioning update). - Added
takeUntilDestroyed(this.destroyRef)to the searchvalueChangessubscription. - Added defensive null checks around
querySelectorresults used in hidden-items calculations to avoid runtime errors when expected DOM nodes are absent.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.