fix(title): don't show tooltip for imperceptible sub-pixel clip (#DS-4292)#1684
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit c8f3c15): https://koobiq-next--prs-1684-irped160.web.app (expires Mon, 06 Jul 2026 14:08:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts KbqTitleDirective overflow detection to avoid showing a tooltip when the text is only clipped by an imperceptible sub-pixel amount (for the default text-overflow: clip case), while still treating sub-pixel overflow as truncation when an ellipsis is actually rendered.
Changes:
- Added an SSR-friendly
KBQ_WINDOWinjection to read computed styles fortext-overflow. - Refactored the “fractional pixel” overflow path to use a dedicated
isWidthOverflownhelper that rounds widths when no ellipsis is present. - Added Jest coverage for sub-pixel clip vs ellipsis behavior across both “text-only” and “container + child element” measurement scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/components/title/title.directive.ts | Uses text-overflow (via KBQ_WINDOW.getComputedStyle) to decide whether sub-pixel width differences should count as visible truncation. |
| packages/components/title/title.directive.spec.ts | Adds unit tests validating the new sub-pixel overflow behavior for clip vs ellipsis, including container-vs-child ellipsis placement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
artembelik
approved these changes
Jul 1, 2026
NikGurev
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.