Repository navigation
Release 0.2.0: drop androidx.preference, read the default SharedPreferences directly - #15
Merged
Merged
Conversation
TCFDataProvider reads `<packageName>_preferences`, the file PreferenceManager.getDefaultSharedPreferences opens, so the kit no longer pulls in appcompat, recyclerview, activity, savedstate, window and the rest through preference-ktx. androidx.browser stays: InAppBrowserManager uses Custom Tabs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
TCFDataProviderreads the IAB TCF keys fromcontext.getSharedPreferences("${packageName}_preferences", MODE_PRIVATE), the same filePreferenceManager.getDefaultSharedPreferencesopens. It is still a one-shot read ofprefs.allon eachcollect(), with no listener before or after, and the parsing and validation have not changed.androidx.preference:preference-ktxis removed frombuild.gradle.kts, and its entries are removed fromgradle/libs.versions.toml.androidx.browserstays.InAppBrowserManager(ui/) opens Custom Tabs withCustomTabsIntent, andsdk-kotlinuses it. No other module declares it::omdepends only on the kit, coroutines and:omsdk-android.TCFDataProviderTestwrites to the prefs file by name, and a new test checks that values written through the framework's default-prefs API are read.Unreleasedentry. The version is left at 0.1.0 for the release PR.Dependencies (
:releaseRuntimeClasspath;:omis the same set plus the kit and OMSDK)60 modules before, 38 after.
Removed:
preference,preference-ktx,appcompat,appcompat-resources,recyclerview,activity,activity-ktx,fragment-ktx,savedstate,savedstate-ktx,lifecycle-viewmodel-savedstate,lifecycle-runtime-ktx,lifecycle-viewmodel-ktx,lifecycle-livedata-core-ktx,core-ktx,collection-ktx,annotation-experimental,tracing,transition,vectordrawable,vectordrawable-animated,window.Lower resolved versions (now set by
browserandplay-services-basement; an app's own newer versions still win):core1.8.0 → 1.2.0,fragment1.3.6 → 1.0.0,lifecycle-*2.5.1 → 2.0.0,arch.core2.1.0 → 2.0.0,customview1.1.0 → 1.0.0,slidingpanelayout1.2.0 → 1.0.0,versionedparcelable1.1.1 → 1.1.0.Still present:
fragment1.0.0,legacy-support-core-ui/-utils,viewpager,drawerlayout,coordinatorlayout,swiperefreshlayout,slidingpanelayoutand others.play-services-ads-identifier18.0.1 brings these in throughplay-services-basement18.0.0 →fragment1.0.0. Cutting those as well would mean changing how the advertising ID is read, which this PR does not do.Testing
./gradlew spotlessCheck detekt build testpassed: 340 unit tests across the kit and:om, with 0 failures and 0 skipped../gradlew :dependenciesand:om:dependencies --configuration releaseRuntimeClasspathbefore and after; the lists above come from that comparison.🤖 Generated with Claude Code