Repository navigation
Separate Open Measurement into kontext-kit-android-om - #13
Merged
Merged
Conversation
…xtkit-ios has KontextKitOM OmManager, OmSession, OmPartner, OmCreativeType and omsdk_v1.js move to the :om module, published as so.kontext.kit:kontext-kit-android-om with the kit's version. Package and class names are unchanged. kontext-kit-android no longer carries the IAB OMSDK AAR, so an SDK without OMID ships no OMSDK binary; the kit now declares kotlinx-coroutines-android, which AdvertisingIdProvider already used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
android-actions/setup-android@v3 asks sdkmanager for the removed 'tools' package and fails; the runner image ships the Android SDK already, as the video SDK's CI relies on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The same step fails on the current runner image; without this the release tag would publish nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open Measurement moves to its own artifact, as kontextkit-ios has
KontextKitOMnext toKontextKit.:ommodule, published asso.kontext.kit:kontext-kit-android-omwith the kit's version. It holdsOmManager,OmSession,OmPartner,OmCreativeTypeand the bundledomsdk_v1.js, and depends on the kit and onso.kontext.iab:omsdk-android(runtime scope, as before).so.kontext.kit.omsdk.*). An SDK that measures with OMID adds one dependency and changes no code:implementation("so.kontext.kit:kontext-kit-android-om:<version>")kontext-kit-androidno longer carries the OMSDK AAR, so an SDK without OMID (the video SDK) ships no OMSDK binary and takes on no OM licence.kotlinx-coroutines-android, whichAdvertisingIdProvideralready used without declaring it.Checked:
assembleDebugandtestpass (the OM tests moved with the code), spotless and detekt clean, andpublishToMavenLocalPOMs as intended (the kit withoutomsdk-android;-omwith the kit andomsdk-android).Breaking for consumers: sdk-kotlin (and the React Native and Flutter Android halves) must add the
-omdependency when they move to this version. sdk-kotlin's composite build against../kontextkit-androidneeds the same. Suggest releasing it as0.1.0.🤖 Generated with Claude Code