Skip to content

fix(cli): classify oversized doctor output deterministically - #49

Merged
tumberger merged 1 commit into
mainfrom
fix/doctor-output-limit
Sep 1, 2026
Merged

tumberger merged 1 commit into
mainfrom
fix/doctor-output-limit

Conversation

@tumberger

Copy link
Copy Markdown
Contributor

Summary

  • keep the native doctor-output file limit one block above the logical parser limit
  • classify output floods through Sandy's bounded-output path instead of racing the child process limit
  • assert the exact oversized-output error without a scheduler-sensitive wall-clock threshold

Verification

  • targeted test on macOS
  • targeted test in arm64 Linux Docker
  • sandy-cli clippy with all targets and features

@greptile-apps

greptile-apps Bot commented Sep 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes Kontext doctor-output flood handling deterministic by setting the native file-size guard one block above Sandy’s logical parser limit and strengthening the regression test to assert the exact bounded-output error.

  • Raises the native doctor-output limit by one platform-specific block.
  • Replaces a scheduler-sensitive elapsed-time assertion with an exact error-classification assertion.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The parent still bounds reads to one byte beyond the logical limit and checks oversized output both during polling and after child exit, while the native guard remains bounded above that threshold.

Important Files Changed

Filename Overview
crates/cli/src/integration/kontext.rs The native limit now leaves enough room for the parent’s bounded reader to detect output above 64 KiB, while the updated test verifies the intended error classification.

Reviews (1): Last reviewed commit: "fix(cli): classify oversized doctor outp..." | Re-trigger Greptile

@tumberger
tumberger merged commit 9531e4b into main Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant