Repository navigation
fix(telemetry): report the running CLI version independently - #514
Merged
Merged
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label queue_me to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
hasandemirkiran
marked this pull request as ready for review
September 18, 2026 15:00
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The daemon currently omits
device.cli_version, so the hosted installation cannot distinguish its running CLI release from an MDM package marker. Report the daemon's linkedBinaryVersionin every ledger batch and idle heartbeat. For example, a daemon running CLI 1.5.2 with an MDM marker of 1.5.1 now sendscli_version: "1.5.2"anddeployment_version: "1.5.1".Preserve the existing deployment marker and self-serve
cli-<version>fallback. Omit unknown/blank CLI versions, and include device metadata when the CLI version is the only available fact. The backend already accepts and persists this optional field.Regression coverage checks the raw JSON for both ledger and heartbeat paths, standalone versions, development builds, omission, marker changes, and daemon-to-stream version plumbing. This reports the linked release label; existing endpoints need a daemon built with this change before they can populate the field.
Verification
go test ./...go test -race ./...go vet ./...go build ./...go mod verifygo run ./cmd/kontext guard smoke-testKONTEXT_E2E_PORT=48783 make guard-e2einternal/managedstream,internal/managedobserve, andcmd/kontextRelease notes