Module 02: Memory Access Patterns update - #188
Conversation
This includes switching from CudaSpace to GPUSpace and expanding a bit on what adding a new custom layout involves. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
lucbv
changed the title
Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
omsai
left a comment
omsai
left a comment
There was a problem hiding this comment.
Might need a word removed and adding two footnotes for folks reading through the slides not attending in person.
|
|
||
| \begin{block}{Important point} | ||
| For performance, accesses to views in \texttt{HostSpace} must be \textbf{cached}, while access to views in \texttt{CudaSpace} must be \textbf{coalesced}. | ||
| For performance, accesses to views in \texttt{HostSpace} must be \textbf{cached}, while access to views in \texttt{GPUmemorySpace} must be \textbf{coalesced}. |
There was a problem hiding this comment.
Is GPUmemorySpace a placeholder? I worry about someone mistakenly looking for exactly this literal symbol in the API and maybe there could be some way of make it more clear that it's a placeholder? A bash-ism would be ${GPUmemorySpace} but I can't think of a well-understood C++ equivalent and so maybe one could qualify it with "your specific GPUmemorySpace" or "your hardware's GPUmemorySpace". We don't have to do this each time, but just need to point it out the first time. If space is at a premium in your block then maybe it could be a footnote.
There was a problem hiding this comment.
Okay, I clarified that with some editing
| \begin{itemize} | ||
| \item{\textbf{HostSpace}: cached ({\color{darkgreen}good})} | ||
| \item{\textbf{CudaSpace}: uncoalesced ({\color{red}bad})} | ||
| \item{\textbf{GPUSpace}: uncoalesced ({\color{red}bad})} |
There was a problem hiding this comment.
Same comment as above; if this isn't an actual symbol in the API, then may want to have a footnote on the slide the first time the placeholder is introduced saying to replace it with your specific hardware's *Space
Now using GPU memory spaces instead to make it more clear that it is not a Kokkos defined type but just the concept of GPU memory. Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
omsai
left a comment
omsai
left a comment
There was a problem hiding this comment.
Looks good! Removing the \texttt{....} formatting is a better solution than the footnote I was suggesting.
2 participants
This includes switching from CudaSpace to GPUSpace and expanding a bit on what adding a new custom layout involves.