Repository navigation
Inner product m rows n columns - #184
Merged
Merged
Conversation
added 2 commits
September 24, 2026 10:37
lucbv
approved these changes
Sep 29, 2026
lucbv
left a comment
Contributor
There was a problem hiding this comment.
Went through the files and the swap between M and N looks correct to me
crtrott
approved these changes
Sep 29, 2026
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The generated medium tutorial deck still documents -N as the row-count option.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Standardizes inner-product examples on M rows and N columns across presentation material and exercises.
Changes:
- Swaps matrix dimensions, loop bounds, and vector extents consistently.
- Updates command-line flags so
-Mcontrols rows and-Ncontrols columns. - Aligns explanatory slides, output, and bandwidth calculations.
| File | Description |
|---|---|
Exercises/team_vector_loop/Solution/team_vector_loop_solution.cpp |
Updates solved vector-loop exercise notation. |
Exercises/team_vector_loop/Begin/team_vector_loop_begin.cpp |
Updates starter vector-loop exercise notation. |
Exercises/team_scratch_memory/Solution/team_scratch_memory_solution.cpp |
Updates solved scratch-memory dimensions. |
Exercises/team_scratch_memory/Begin/team_scratch_memory_begin.cpp |
Updates starter scratch-memory dimensions. |
Exercises/team_policy/Solution/team_policy_solution.cpp |
Updates solved team-policy dimensions. |
Exercises/team_policy/Begin/team_policy_begin.cpp |
Updates starter team-policy dimensions. |
Exercises/subview/Solution/exercise_subview_solution.cpp |
Updates solved subview exercise notation. |
Exercises/subview/Begin/exercise_subview_begin.cpp |
Updates starter subview exercise notation. |
Exercises/mdrange/Solution/exercise_mdrange_solution.cpp |
Updates solved MDRange dimensions. |
Exercises/mdrange/Begin/exercise_mdrange_begin.cpp |
Updates starter MDRange dimensions. |
Exercises/kokkoskernels/InnerProduct/Solution/innerproduct.cpp |
Updates Kokkos Kernels implementation dimensions. |
Exercises/kokkoskernels/InnerProduct/Begin/innerproduct.cpp |
Updates Kokkos Kernels starter dimensions. |
Exercises/04/Solution/exercise_4_solution.cpp |
Updates Exercise 4 solution notation. |
Exercises/04/Begin/exercise_4_begin.cpp |
Updates Exercise 4 starter notation. |
Exercises/03/Solution/exercise_3_solution.cpp |
Updates Exercise 3 solution notation. |
Exercises/03/Begin/exercise_3_begin.cpp |
Updates Exercise 3 starter notation. |
Exercises/02/Solution/exercise_2_solution.cpp |
Updates Exercise 2 solution notation. |
Exercises/02/Begin/exercise_2_begin.cpp |
Updates Exercise 2 starter notation. |
Exercises/01/Solution/exercise_1_solution.cpp |
Updates Exercise 1 solution notation. |
Exercises/01/Begin/exercise_1_begin.cpp |
Updates Exercise 1 starter notation. |
Content/Presentations/sections/Section_Views.tex |
Updates row-count CLI guidance. |
Content/Presentations/sections/Section_Spaces.tex |
Updates row-count CLI guidance. |
Content/Presentations/sections/Section_ScratchSpace.tex |
Updates row-count CLI guidance. |
Content/Presentations/sections/Section_MemoryAccessPatterns.tex |
Updates dimensions and iteration bounds. |
Content/Presentations/sections/Section_KokkosKernels_BLAS.tex |
Updates BLAS inner-product notation. |
Content/Presentations/sections/Section_Hierarchical.tex |
Updates hierarchical parallelism dimensions. |
Content/Presentations/sections/Section_DataParallelPatterns.tex |
Updates recurring exercise notation and flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As per issue #162 One of the items is to match the textbook notation of M rows and N columns style for the Presentation slides for easier understanding.
The PR does the following: