Repository navigation
Add unit tests for the "Subtree of Another Tree" problem. - #40
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a proper packaged implementation and unit tests for the LeetCode “Subtree of Another Tree” (572) problem, aligning it with the existing com.leetcode.easy structure.
Changes:
- Introduced
SubtreeOfAnotherTree572undersrc/main/java/com/leetcode/easy/usingcom.leetcode.datastructure.TreeNodeand added detailed time/space complexity documentation. - Added
SubtreeOfAnotherTree572Testundersrc/test/java/com/leetcode/easy/with JUnit 5 tests that cover the main LeetCode examples. - Removed the old default‑package
src/SubtreeOfAnotherTree572.javaimplementation and its demomainmethod in favor of the new structured layout.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/leetcode/easy/SubtreeOfAnotherTree572.java | New packaged implementation of the subtree check with helper isSameTree and documented complexity. |
| src/test/java/com/leetcode/easy/SubtreeOfAnotherTree572Test.java | New JUnit test class validating isSubtree against the two standard example cases. |
| src/SubtreeOfAnotherTree572.java | Legacy default‑package implementation and demo main removed now that a structured class and tests exist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+43
to
+47
| if (subRoot == null) { | ||
| return true; | ||
| } | ||
| if (root == null) { | ||
| return false; |
There was a problem hiding this comment.
The branches handling subRoot == null and root == null are not covered by the new tests; consider adding unit tests in SubtreeOfAnotherTree572Test for cases like (root = null, subRoot != null) and (root != null, subRoot = null) to exercise these code paths and guard their behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.