Skip to content

upgrade: Button for Solid 2 (closes #655) - #689

Open
devx wants to merge 6 commits into
kobaltedev:solid2from
devx:pr/upgrade-button
Open

upgrade: Button for Solid 2 (closes #655)#689
devx wants to merge 6 commits into
kobaltedev:solid2from
devx:pr/upgrade-button

Conversation

@devx

@devx devx commented Jul 17, 2026

Copy link
Copy Markdown

Closes #655.

Summary

Upgrades `Button` for Solid 2.0 on top of @davedbase's #673 sweep. Suppresses STRICT_READ_UNTRACKED by extracting the ref callback with `untrack` to avoid reactive tracking of the ref prop.

Verification

  • `pnpm -F @kobalte/core typecheck` — 0 errors (excluding pre-existing `minimal-dialog.test.tsx` hardcoded path)
  • `vitest run src/button/button.test.tsx` — 15/15 passing

Changeset

`.changeset/upgrade-button-solid2.md` marks `@kobalte/core` as patch.

Notes

@jer3m01

jer3m01 commented Jul 18, 2026

Copy link
Copy Markdown
Member

Thanks for the PR!

In Solid 2 ref already handles the merging built in, mergeRefs will get removed once the port is over.
Not sure however of the exact syntax, I believe it's an array for ref (might need to test yourself or find it somewhere in the infinite discord discussion).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants