Conversation
Member
|
Looks nice! Previous PR would be good to check/compare to #523 (didn't end up getting finished). Some comments might apply, will do a full review once current components have been fully ported. |
Author
Ah good point, I should pay more attention to existing PRs. I reviewed 523 and took some pointers from it. Import/formatting fixes
New API Reference sections (previously undocumented entirely)
Existing sections corrected
New top-level section
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #520
Stepscomponent (@kobalte/core/steps) modeled on Ark UI's Steps, following Kobalte's existing anatomy/context conventions:Root,List,Item,Trigger,Indicator,Separator,Content,CompletedContent,Progress,NextTrigger,PrevTrigger.countsteps navigated by index) rather than a dynamic collection — no DOM-collection/roving-tabindex machinery needed, unlikeTabs/ToggleGroup.linearmode (forward navigation gated byisStepValid, backward always allowed),isStepSkippableto bypass steps during next/prev navigation, a dedicated completed state (CompletedContent), aProgresspart plus a--percentCSS variable on the root, and controlled/uncontrolledvalue.Content/CompletedContentcopiedTabs.Content'screatePresence-based transition pattern, but its exit path always goes through a real (if 0ms)setTimeout, leaving a one-tick window where the outgoing and incoming step's content were both mounted at once — visible as a flicker on every step change. Replaced with a plain<Show>for an atomic swap;forceMountstill available for consumers who want to drive their own CSS transitions.Separatoris nowaria-hidden="true"(matchingBreadcrumbs.Separator), andTrigger/Contentare now cross-referenced viaaria-controls/aria-labelledbywith auto-generated (overridable) ids (matching howTabslinks its triggers and panels).docs/core/components/steps.mdx(Import/Features/Anatomy/Example/Usage/API Reference/Rendered Elements) plus live examples, and a nav entry.