Skip to content
This repository was archived by the owner on Aug 31, 2024. It is now read-only.

upgrade koa-compose to 4#11

Open
zavr-1 wants to merge 1 commit into
koajs:masterfrom
dpck:master
Open

upgrade koa-compose to 4#11
zavr-1 wants to merge 1 commit into
koajs:masterfrom
dpck:master

Conversation

@zavr-1

@zavr-1 zavr-1 commented Apr 18, 2019

Copy link
Copy Markdown

remove any-promise

@dead-horse

Copy link
Copy Markdown
Member

can you update the node versions in .travis.yml to pass the CI?

@gyson

gyson commented Apr 18, 2019

Copy link
Copy Markdown
Member

koa-compose dependency is only used for convert.compose function at

convert.compose = function (arr) {

I feel that the benefit of convert.compose (a little bit convenience) does not overcome the cost of koa-compose dependency.

Maybe we should remove convert.compose (this is a breaking change and requires koa-convert major version change) and drop koa-compose dependency?

@zavr-1

zavr-1 commented Apr 18, 2019

Copy link
Copy Markdown
Author

please note i've started this issue in koa koajs/koa#1323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants