chore(KNO-9956): Convert Knock specific Liquid helpers table to AccordionGroup - #1645
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…calization parameters
rachael-t
marked this pull request as ready for review
August 28, 2026 20:40
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Risk MEDIUM: Converts the Knock-specific Liquid helpers wide table to topic-grouped AccordionGroup sections and reorganizes localization/formatting reference content on an existing MDX page.
Reasons
- Single file changed (
content/template-editor/reference-liquid-helpers.mdx) with no component, layout, lib, or config modifications - Substantial content rewrite: 194 additions and 248 deletions (well above the 30+/30+ MEDIUM threshold)
- Restructures helper documentation from one wide
Tableinto multipleAccordionGroupsections (date/time, numbers/currency, text/data, hashing) - Reorganizes localization parameters and date/time format option sections within the page
- Author
rachael-tis a known repository contributor; no approval issued because risk is MEDIUM
Notes
- Verify the Vercel preview at narrow and wide viewports to confirm the sidebar overlap issue is resolved
- Spot-check that all helpers from the original table appear in the new accordion sections with correct examples and outputs
- Confirm internal anchor links (e.g.
#localization-parameters,#date-format-options) resolve correctly from within accordion content - Review the new "Dynamic data filters" table at the bottom of the page for accuracy and completeness
Sent by Cursor Automation: Docs PR classifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the Knock-specific Liquid helpers table is too wide at certain viewport sizes and causes an overlap of the sidebar and “Edit this page” area:
While discussing different solutions and how to ensure this info scales as we continue adding to it, the DSE team decided to convert the table to use the
AccordionGroupcomponent. The different helpers are reorganized into topic-based groups for better scannability, and the localization parameter and date/time format options information is moved up to the relevant helpers section.https://docs-git-rt-kno-9956-convert-liquid-helpers-table-knocklabs.vercel.app/template-editor/reference-liquid-helpers#knock-specific-liquid-helpers
Tasks
KNO-9956