Skip to content

chore(kno-14990): document liquid support in MJML - #1644

Merged
cellomatt merged 2 commits into
mainfrom
mk-kno-14990
Aug 28, 2026
Merged

chore(kno-14990): document liquid support in MJML#1644
cellomatt merged 2 commits into
mainfrom
mk-kno-14990

Conversation

@cellomatt

Copy link
Copy Markdown
Member

Description

This PR does two things:

  • Document support for Liquid in MJML layouts and templates, including limitations and workarounds
  • Fix incorrect references to <mjml-raw> -> <mj-raw>

@linear-code

linear-code Bot commented Aug 27, 2026

Copy link
Copy Markdown

KNO-14990

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview Aug 28, 2026 5:58pm

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk MEDIUM: Documents Liquid support in MJML layouts and templates, and corrects <mjml-raw> references to <mj-raw> across three MDX files.

Reasons

  • Changes span two documentation sections: content/integrations/email/ (2 files) and content/template-editor/ (1 file)
  • Large content addition to mjml.mdx (~203 lines) covering Liquid placement rules, troubleshooting, and accordion examples
  • Total diff is 226 lines changed (206 additions, 20 deletions), well above the LOW-risk threshold
  • No code, config, sidebar, or OpenAPI spec changes — no HIGH-risk triggers matched
  • Author cellomatt is a known team member

Notes

  • Verify the MJML compile → Liquid render two-step explanation matches actual Knock behavior
  • Review Liquid placement table and accordion examples for technical accuracy (especially <mj-font>, <mj-attributes>, and <mj-breakpoint> workarounds)
  • Confirm all internal cross-links resolve (/template-editor/reference-liquid-helpers, /integrations/email/layouts, /template-editor/partials/html-partials)
  • Spot-check that <mj-raw> tag corrections are consistent across all three files
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

Comment thread content/integrations/email/mjml.mdx
Comment thread content/integrations/email/mjml.mdx Outdated

@rachael-t rachael-t left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

Left a small question, but it's not blocking.

Comment thread content/integrations/email/mjml.mdx Outdated
@cellomatt
cellomatt merged commit ffff061 into main Aug 28, 2026
4 checks passed
@cellomatt
cellomatt deleted the mk-kno-14990 branch August 28, 2026 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants