perf: hoist F16 weight row conversion out of the token loop - #430
Open
unsafePtr wants to merge 1 commit into
Open
perf: hoist F16 weight row conversion out of the token loop#430unsafePtr wants to merge 1 commit into
unsafePtr wants to merge 1 commit into
Conversation
GemmF16 and GemmTiledF16Worker iterated token-first with the weight row loop inside, so each row's F16 to F32 conversion was redone once per token instead of once. Reordering to row-outer / token-inner converts each row once and dots it against all N tokens. Also adds the F16 coverage GemmBenchmarks was missing, which is why this went unmeasured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After