Add FreeBSD amd64 and arm64 builds and installation - #18
Merged
Merged
Conversation
Build and test FreeBSD 13.5 binaries for amd64 and arm64, and include them in release checksums and provenance attestations. Support native FreeBSD download and checksum tools in the installer, fail when verification is unavailable, and validate FreeBSD ELF architecture. Update the CI runner and preserve version-command failures.
kjanat
added
bug
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b99c6f2f8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Use the requested reusable-workflow reference and isolate test builds from the release version override. Update the VM configuration, Node version, timeout, and artifact paths.
Run the installer with POSIX sh and let ShellCheck infer each script's shell. Detect reversed environment insertion in the test launcher while preserving exact fixture assertions. Update the documented install command and formatter plugins.
Share the artifact name and path through YAML anchors so the upload step no longer depends on environment variables scoped to the VM step.
Run the arm64 VM job on ubuntu-26.04-arm and the amd64 job on ubuntu-26.04 instead of sharing an x86 runner.
Check build prerequisites before fetching the selected release tag. Use a sparse Git checkout, or download the tag archive when Git is unavailable, then compile and verify the installed version. Preserve fatal checksum and attestation failures. Support mingw32-make and avoid MSYS sparse-pattern conversion. Limit FreeBSD CI to amd64 and make the artifact verifier executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeBSD installations currently fail because the installer rejects the OS and releases contain no matching binary. Add FreeBSD 13.5 VM builds and tests for amd64 and arm64, with both artifacts included in the existing release checksums and provenance attestations.
The installer now recognizes FreeBSD, supports its native
fetchandsha256tools, and fails when checksum verification is unavailable. Artifact checks validate the FreeBSD ELF ABI and architecture. Also updates the CI runner to v0.26.2 and preserves failures from the installed-version command.Validation:
make test: 300 core tests, 18 round trips, and bash/zsh/fish completion checks passed locally.node --test tests/action.test.mjs: all 24 tests passed./usr/bin/actionlint -shellcheck="/usr/bin/shellcheck -x -o all", formatting, shell syntax, and diff checks passed.The FreeBSD VM jobs have not yet run. Compatibility with the FreeBSD 13.1 jail remains to be verified.