fix(BorrowerProfile): render the server-provided loan status label AD-475 - #7213
Merged
Conversation
…y ran The apollo result handler always read fullProfileQuery out of the cache, so on the minimal-view path that read missed and the loan fell back to the routing and share-meta seed. Any field belonging only to minimalProfileFields was therefore absent from the server-rendered markup. The handler now runs the same showFullView decision as preFetch and reads back whichever child query was prefetched. AD-475
The component carried its own status-to-label map, written the day before the API gained a statusLabel field, and the two had since drifted: reviewed, inactiveExpired and defaulted all displayed text the API no longer agreed with. The borrower profile queries now request statusLabel and pass it down, and the map, the currency-loss branch and the delinquent branch are gone since getHumanizedStatus covers all three server-side. AD-475
dyersituations
approved these changes
Sep 2, 2026
mcstover
approved these changes
Sep 2, 2026
Collaborator
|
🎉 This PR is included in version 3.92.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Collaborator
|
🎉 This PR is included in version 3.92.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Volunteers noticed that two loan statuses are displaying the wrong label on the borrower profile:
reviewedstatus loans display "Under review" instead of "Reviewed", andinactiveExpiredstatus loans display "Inactive" instead of "Inactive expired". Investigating that revealed that there was a step missed during the migration to use thestatusLabeldefined by the backend (added in AD-220), so this PR completes that missing step.Additionally, I found that the
BorrowerProfilequery result handler was not reading the minimal query from the cache when it was prefetched, and it was falling back to only using the loan data used for the routing decision instead. I fixed that by making it use the sameshowFullViewmethod that the prefetch uses to decide between the full and minimal queries.