refactor: remove legacy contentful theme mappings - #7208
Merged
Conversation
The deprecated theme values have been migrated out of Contentful, so the fallback entries that mapped them onto approved themes are dead code. StoryCard and SectionWithBackgroundClassic now accept only the five approved values plus imageCard, which is a layout rather than a colour theme. Anything else falls through to the default theme as before.
mcstover
approved these changes
Aug 31, 2026
eddieferrer
marked this pull request as ready for review
September 1, 2026 14:59
kiva-robot
added a commit
that referenced
this pull request
Sep 1, 2026
## [3.91.0-rc.1](v3.90.0...v3.91.0-rc.1) (2026-09-01) ### 🎉 New Features * **live-loan:** render compact bundle card as transparent PNG ([#7204](#7204)) ([131e350](131e350)) ### 🐛 Bugfixes * avoid firing close event on set 2027 goal cta ([2f6a85d](2f6a85d)) * **header:** sync ESI CSS variables for the new header states ([c1da5ba](c1da5ba)) * mykiva initial loading performance improvements ([#7203](#7203)) ([5e836e2](5e836e2)) * opt the header into the ESI avatar ([5f9b4c4](5f9b4c4)) * release withdraw page migration ([#7210](#7210)) ([68a8429](68a8429)) * update kv-components with latest esi support for user avatar ([a54da72](a54da72)) ### 🪚 Refactors * remap deprecated Contentful theme values to approved themes ([#7199](#7199)) ([a9e6de8](a9e6de8)) * remove legacy contentful theme mappings ([#7208](#7208)) ([4fd6d12](4fd6d12)) ### 🧹 Chores * update kv-components with latest KvWwwHeaderBasic fixes ([28d6e96](28d6e96)) * upgrade kv-tokens to 5 and kv-components to 9 ([#7205](#7205)) ([c708e64](c708e64))
Collaborator
|
🎉 This PR is included in version 3.91.0-rc.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiva-robot
added a commit
that referenced
this pull request
Sep 1, 2026
## [3.91.0](v3.90.0...v3.91.0) (2026-09-01) ### 🎉 New Features * **live-loan:** render compact bundle card as transparent PNG ([#7204](#7204)) ([131e350](131e350)) ### 🐛 Bugfixes * avoid firing close event on set 2027 goal cta ([2f6a85d](2f6a85d)) * **header:** sync ESI CSS variables for the new header states ([c1da5ba](c1da5ba)) * mykiva initial loading performance improvements ([#7203](#7203)) ([5e836e2](5e836e2)) * opt the header into the ESI avatar ([5f9b4c4](5f9b4c4)) * release withdraw page migration ([#7210](#7210)) ([68a8429](68a8429)) * update kv-components with latest esi support for user avatar ([a54da72](a54da72)) ### 🪚 Refactors * remap deprecated Contentful theme values to approved themes ([#7199](#7199)) ([a9e6de8](a9e6de8)) * remove legacy contentful theme mappings ([#7208](#7208)) ([4fd6d12](4fd6d12)) ### 🧹 Chores * **release:** 3.91.0-rc.1 [skip ci] ([8170347](8170347)), closes [#7204](#7204) [#7203](#7203) [#7210](#7210) [#7199](#7199) [#7208](#7208) [#7205](#7205) * update kv-components with latest KvWwwHeaderBasic fixes ([28d6e96](28d6e96)) * upgrade kv-tokens to 5 and kv-components to 9 ([#7205](#7205)) ([c708e64](c708e64))
Collaborator
|
🎉 This PR is included in version 3.91.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: CIT-5073
Summary
kivaClassicMint,kivaClassicGreen,kivaClassicDark,kivaClassicDarkStone,kivaDarkMintandecoStoneDarkentries from the theme mappers inStoryCard.vueandSectionWithBackgroundClassic.vue. Those values no longer exist in Contentful (dev or master) after the CIT-5073 migration, so the mappings were dead code.imageCard, which is a layout rather than a colour theme —StoryCardkeys its background-image treatment off.story-card__imageCard.themeNameprop docs onSectionWithBackgroundClassic, which still described the legacy values as rendering "until they are retired in Contentful".