fix(KvWwwHeaderBasic): tablet position of Major gifts, empty mobile drawer - #901
Merged
Merged
Conversation
The tablet grid-template-areas declared four columns on the top row and three on the search row. A value whose rows differ in length is invalid and dropped whole, so the majorgifts area never existed and the link auto-placed into an implicit row below the search bar.
… open The drawer panel opens from CSS the instant the hamburger is clicked, but its content is an async chunk only requested once the group is approached. A page loaded at desktop width never approaches the group — it is display:none — so resizing down and tapping opened a full-screen empty white panel while the chunk was still in flight. Adds a prewarm prop that mounts panel content without an approach, set from isMobile on the drawer group.
dyersituations
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes to the major gifts header experiment.
Tablet layout. The
mdgrid-template-areasdeclared four columns on the top row and three on the search row. A value whose rows differ in length is invalid and dropped whole, with no console warning, so themajorgiftsarea never existed and the link auto-placed into an implicit row below the search bar. Major gifts now sits alongside the Lend dropdown as intended.Empty mobile drawer. The drawer panel opens from CSS the instant the hamburger is clicked, but
MobileMenuis an async chunk only requested once the group is approached. A page loaded at desktop width never approaches the group — it isdisplay:none— so resizing down and tapping opened a full-screen white panel with no links while the chunk was still in flight. Adds aprewarmprop onHeaderMenuGroupthat mounts panel content without an approach, set fromisMobileon the drawer group.https://kiva.atlassian.net/browse/CIT-5183