feat(CIT-5115): source the lend menu from browsingCategories - #893
Merged
Conversation
browsingCategories sits on the Query root rather than under lend, so the inline lendMenuData document and its one data path change. Nothing reads category.id, so the Int -> UUID shift is inert.
meganmcmillan
approved these changes
Sep 2, 2026
meganmcmillan
left a comment
meganmcmillan
left a comment
There was a problem hiding this comment.
Spot checked a few of the category ids in the map and they matched across dev and prod. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CIT-5115
Moves
KvLendMenu's inlinelendMenuDataquery off the deprecatedlend.loanChannelsontobrowsingCategories. Counterpart of kiva/ui#7115 and kiva/cms-page-server#3164 — the shared header is the last live usage in either app.browsingCategoriesis on theQueryroot, so the data path moves out oflend. Sorting, thelend-by-categoryurl rewrite and the loading flags are unchanged; nothing readscategory.id, so theInt→ UUID change is inert. The Storybook mock's fixture is refreshed to the 17 categories dev returns.