Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 94.87% 94.78% -0.09%
==========================================
Files 10 12 +2
Lines 351 441 +90
==========================================
+ Hits 333 418 +85
- Misses 18 23 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Added some docs and tests. It is a bit difficult coming up with a name for this material. It does not really have an author associated with it since it is pretty standard. It also has some simplifications in the local integration, and I can Imagine other users will want to implement similar materials without these simplifications... Maybe we should have a very explicit name for the material, even though it will be long and ugly. |
|
Good question. Is there any name behind the unsimplified version, such that it could be called something like We could also split the section about materials in the docs into subsections, e.g. |
Sounds good I will go with the name |
To show an example for PR #35
Relevant lines:
So two methods for material_response are implemented, but they share the same function that does all the computation.
@kimauth let me know what you think :)