chore: khmer translation now uses busra font#752
Conversation
User Test ResultsTest specification and instructions User tests are not required |
| /* Khmer */ | ||
| :lang(km) { | ||
| /* The browser will automatically use Busra for Khmer chars and Cabin or Sans-serif for others */ | ||
| font-family: 'Busra','Cabin', sans-serif; | ||
| } | ||
|
|
There was a problem hiding this comment.
-
For maintainability, can we move this alphabetically before Lao (line 289)?
-
I don't know CSS. Are Cabin and sans-serif already handled in line 173? (I note the other languages only reference one font for family, and not in quotes)
There was a problem hiding this comment.
I'll try removing the two fonts to see if Busra is working properly or not. I added the Unicode range after font-family so this might fix it without having to specify three fonts.
There was a problem hiding this comment.
I've got the answer now. The Cabin and sans-serif fonts are there as a fallback for other characters that aren't Khmer.
Since I use lang(km) to recognize the km in the URL (http://keyman.com.localhost:8053/km/keyboards/?q=k&x=0&y=0) to trigger a font change, it changes the font for the entire web page.
Busra font:
keyman.com:
Whereas the other font-family properties are being used for .lang-example selectors, so it does not impact any other elements; therefore, one value for font-family is enough.
3 participants
This PR calls Busra font for Khmer translation (with Unicode range) on the website. Changing to this font allow easy skim reading, clearer and bolder characters, and readability. Please review.
Test-bot: skip
User Interfaces
URL: http://keyman.com.localhost:8053/km/keyboards/
URL: http://keyman.com.localhost:8053/km/downloads/
