Skip to content

Small fixes #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nuclearcat wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Small fixes #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3fb5bd
dashboard: Add delay with exp() backoff to prevent flooding backend
nuclearcat Apr 9, 2026
5c3b216
bisect: Return proper error code on kci-dev execution error
nuclearcat Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kcidev/libs/dashboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ def wrapper(
logging.warning(
f"Retrying request due to status {r.status_code} (attempt {retries}/{max_retries})"
)
# Delay before retrying, to prevent hammering the server with exponential backoff
time.sleep(2**retries)
Copy link
Copy Markdown
Member

@aliceinwire aliceinwire Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why adding a commit and fixing it in a second commit?
just fix this on your first commit

continue
else:
logging.error(
Expand Down
2 changes: 1 addition & 1 deletion kcidev/subcommands/bisect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def bisection_loop(state):
except Exception as e:
logging.error(f"Error getting return code from kci-dev: {e}")
kci_err(f"Error executing kci-dev, no returncode: {e}")
sys.exit
sys.exit(1)

logging.info(f"Test completed with return code: {testret}")

Expand Down
Loading