Fix: topbar page title#1880
Open
MarceloRobert wants to merge 1 commit intokernelci:mainfrom
Open
Conversation
Fixes the page title for the topbar, using only the route instead of the redirect state + route Closes kernelci#1855
MarceloRobert
added
the
Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the page title for the topbar, using only the route instead of the redirect state + route
Changes
How to test
Go from treeDetails to build/test/issueDetails page and see that even though the breadcrumb is present, the title is the current page (instead of staying at "Tree" like the old behavior). The same happens for hardwareDetails. Compare with the old behavior on staging/production.
Example
Before:
After:
Tested on localhost issue using submissions data.
Closes #1855