Fix: path search on treeDetails#1878
Open
MarceloRobert wants to merge 2 commits intokernelci:mainfrom
Open
Conversation
MarceloRobert
added
bug
MarceloRobert
force-pushed
the
fix/test-path-filter
branch
from
74abf48 to
b897cbb
Compare
Collaborator
Author
|
Moved to draft because we discussed about changing the behavior of the filter to not apply the path filter on the summary endpoint, which won't lose a lot of functionality while increasing the performance massively |
change test path filter to be frontend-only Closes kernelci#1872
MarceloRobert
force-pushed
the
fix/test-path-filter
branch
from
b897cbb to
a0aaad6
Compare
Adds a fallback to the legacy query if an user accesses the summary endpoint with a path filter, even if the frontend doesn't access it anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a path filter would make the rollup rows filter the entire path group instead of only filtering individual tests.
For the solution, legacy rows have to be used since the aggregated rows don't have information about individual tests.We opted for a solution where the test path filter only applies to the table in the frontend, without making changes in the backend so that we don't fallback to the legacy query and the path filtering becomes faster too.The tests were being filtered correctly, but the summary was returning empty and was causing all the frontend components to be replaced with a "no data" too.
Changes
Since these changes are in the core component, they work in the treeDetails page, hardwareDetails page, and buildDetails page (that has a testTable).
How to test
Check any treeDetails page and try applying a test or boot path filter that only works on a subset of a group (ex "nfs" for "boot.nfs" or "setup" for "tast.setup"). Then compare with the production state.
Closes #1872