Repository navigation
Pass Semgrep inputs to the scan step through env - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Run Semgrep step interpolated
inputs.extra-configsand the PR base SHA directly into the shell script, which Semgrep's own run-shell-injection rule flags. Both now arrive throughenv:.EXTRA_CONFIGSis still word-split, since callers pass flags like--config p/golang --config p/trailofbits.set -fstops a*in it from globbing. Word splitting doesn't evaluate;or$(...), so a value can only add arguments tosemgrep scan.BASELINE_COMMITis quoted.test_semgrep_triage.pyasserts the script has no${{ }}and reads both values from env.Tested:
python -m unittest discover -s scripts -p test_semgrep_triage.py(25 pass), plus a shell check that the split keeps each flag and leaves*,;and$(id)as literal arguments.