Skip to content

Lock workflow action dependencies with actions.lock - #219

Closed
rgarcia wants to merge 1 commit into
mainfrom
hypeship/actions-lockfile
Closed

rgarcia wants to merge 1 commit into
mainfrom
hypeship/actions-lockfile

Conversation

@rgarcia

@rgarcia rgarcia commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Adds GitHub's workflow dependency lockfile. .github/workflows/actions.lock records the commit behind every action the workflows use. Runs are checked against it, so a moved tag on a third-party action can't change what runs in CI.

  • Added .github/workflows/actions.lock, generated with gh actions-lock --no-narrow. gh actions-lock --verify passes (all 8 workflows valid).
  • The generated workflows keep their SHA-pinned uses: lines exactly as emitted, so the next generator promotion doesn't conflict with this change. The lockfile is keyed by those SHAs.
  • One line changes: in release-please.yml, pnpm/action-setup@f40ffcd… was the SHA of the annotated v4 tag object, not a commit, and the lockfile can't record it. It now pins pnpm/action-setup@b906aff… # v4.3.0, the commit that tag points to, so the code that runs is the same.
  • Not covered: the job-level reusable workflows from kernel/security-workflows/...@main (semgrep.yml, vuln-remediation.yml). A lockfile doesn't cover job-level reusable workflow calls.

Follow-up: when the generator bumps an action pin, actions.lock has to be regenerated in the same change. Otherwise runs of that workflow fail at startup.

@rgarcia
rgarcia requested a review from tnsardesai November 13, 2026 21:12
@rgarcia
rgarcia force-pushed the hypeship/actions-lockfile branch from d8fe57b to fab5304 Compare November 13, 2026 21:30
@rgarcia

rgarcia commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by kernel/kernel-python-sdk-staging#14 (https://github.com/kernel/kernel-python-sdk-staging/pull/14), which landed the same change on staging; promotion has carried it to next (a0d2e4c) and it ships with the next release.

@rgarcia rgarcia closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant