Repository navigation
Conversation
|
Semgrep: 55 findings detected Too many findings to triage automatically (limit: 20). Next steps:
|
Contributor
Author
|
Closing in favor of https://github.com/kernel/kernel-node-sdk-staging/pull/19 (same change: actions.lock via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitHub's workflow dependency lockfile.
.github/workflows/actions.lockrecords the exact commit behind every action the workflows use, and the runner refuses to run an action whose resolved commit doesn't match. A moved or hijacked tag on a third-party action can no longer change what runs in CI..github/workflows/actions.lock, generated withgh actions-lock --no-narrowso the generator's existinguses:lines (commit-SHA pins) stay exactly as they are; the lockfile records those SHAs.uses:line changes, inrelease-please.yml:pnpm/action-setupwas pinned tof40ffcd…, the SHA of the annotatedv4tag object rather than a commit, which the lockfile can't record. It is now pinned tob906aff…, the commit that tag points to, so the same code runs as before.kernel/security-workflows/.github/actions/llm-credentialsstays pinned by commit SHA and is recorded in the lockfile.Not covered: job-level reusable workflow calls (
semgrep.yml,vuln-remediation.yml→kernel/security-workflows/...@main). Theredis:7-alpineservice container inupdate-mcp-coverage.ymlis also not covered (the lockfile pins actions, not images).Codegen / staging: these workflows are generated and promoted from
kernel-node-sdk-staging. This PR only adds a new file (plus the one-line pnpm fix), so promotion merges shouldn't conflict. But when staging changes auses:line,actions.lockhas to be refreshed withgh actions-lock --no-narrowin the same change, or CI/publish here will fail. Therelease-please.ymlpnpm pin on staging has the same tag-object SHA and should get the same fix there.gh actions-lock --verifypasses (all 10 workflows valid).uses:line, rungh actions-lock --no-narrow, and commit both files.