Repository navigation
Restore generator-emitted action pins under actions.lock - #27
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #26. That PR rewrote the SHA-pinned
uses:lines in the generator-owned workflows to release tags, so they no longer match what the SDK generator emits. A later generation would revert them and could conflict with them as custom code.uses:line goes back to exactly what the generator emitted (<sha> # <version>), with one exception:release-please.ymlpinnedpnpm/action-setup@f40ffcd…(# v4). That is the SHA of the annotatedv4tag object, not a commit, so it can't be locked. It now pinsb906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0, the commit that tag points to, so what runs doesn't change..github/workflows/actions.lockwas regenerated withgh actions-lock --no-narrow, so it records each action by SHA along with its release tag. All workflows are onboarded, includingrelease-please.yml.gh actions-lock --verifypasses.b906affforpnpm/action-setup, the next promotion will match this line.kernel/security-workflows/...@main.