Repository navigation
Conversation
|
Semgrep: 21 findings detected Too many findings to triage automatically (limit: 20). Next steps:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6fe4131. Configure here.
|
Semgrep: 21 findings detected Too many findings to triage automatically (limit: 20). Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds GitHub's workflow dependency lockfile.
.github/workflows/actions.lockrecords the exact commit behind every action the workflows use, and the runner refuses to run an action whose resolved commit doesn't match. A moved or hijacked tag on a third-party action can no longer change what runs in CI..github/workflows/actions.lock, generated with gh actions-lock (not hand-edited).uses:line is now an exactvX.Y.Zrelease, and the commit SHAs live in the lockfile. Floating refs intest.yaml,preview.yamlandrelease.yamlwere narrowed (e.g.actions/checkout@v6→v6.1.0,goreleaser/goreleaser-action@v7→v7.3.0).fix-ci.yamlandfix-ci-security.yamlwere SHA-pinned. They are now written as release tags, and each tag's locked commit is the SHA it replaces (also checked against the upstream tag):actions/checkoutd23441a48e51v6.1.0d23441a48e51actions/create-github-app-token64ab729a6294v3.3.064ab729a6294actions/download-artifactd3f86a106a0bv4.3.0d3f86a106a0bactions/setup-go924ae3a1cdedv6.5.0924ae3a1cdedactions/setup-node249970729cb0v6.5.0249970729cb0actions/upload-artifactea165f8d65b6v4.6.2ea165f8d65b6kernel/security-workflows/.github/actions/llm-credentialsstays pinned to its 40-char SHA because that commit has no release tag. It is recorded in the lockfile..github/tests/fix-ci-security.test.mjs: the "actions are pinned" check used to require a 40-char SHA. It now requires eachuses:infix-ci.yamlto be an exactvX.Y.Z(a 40-char SHA only for commits without a release tag, or$/for same-repo actions), and requiresfix-ci.yamlto be onboarded inactions.lockwith an entry for that exact ref. The persist-credentials/token check and every other test are unchanged.Not covered: job-level reusable workflow calls (
breakglass.yml,semgrep.yml,vuln-remediation.yml→kernel/security-workflows/...@main). The lockfile does not lockjobs.<id>.uses; those are unchanged.gh actions-lock --verifypasses (all 8 workflows valid), andnode --test .github/tests/fix-ci-security.test.mjspasses.uses:line, rungh actions-lock, and commit both files.