Repository navigation
Conversation
kernel login asked for "openid email" at authorization and on every refresh. Neither scope does anything for the CLI: it reads no ID token and no email claim. The authorization server treats an absent scope as openid, so the request is now sent without one, and what a login may do is decided on the server's consent page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kernel loginno longer names OAuth scopes. It used to sendscope=openid emailon the authorization request and on every token refresh; both requests now omitscope.Why
emailonly added a line to the consent page.openid emailfor the CLI. Released binaries keep sending it, so the server keeps accepting it for now.Compatibility
scopeasopenid, which the CLI's client registration already allows, so login works against today's server unchanged.scopereturns a token for everything the login was granted, which is what the CLI wants.Testing
make testpasses.scopeparameter, and the refresh request carries noscopefield.