Skip to content

Follow up on Go SDK v0.148.0 coverage - #319

Open
masnwilliams wants to merge 2 commits into
mainfrom
hypeship/cli-coverage-followups
Open

masnwilliams wants to merge 2 commits into
mainfrom
hypeship/cli-coverage-followups

Conversation

@masnwilliams

@masnwilliams masnwilliams commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-ups to the Go SDK v0.148.0 coverage update.

  • No retry on browsers live-view create. Each call mints a live view URL that cannot be revoked, so a retry after a lost response could leave an extra live URL the caller never sees. The call now passes option.WithMaxRetries(0), matching browsers webmcp invoke and deploy.
  • README. Documents browsers live-view create (--scope, --ttl-seconds, -o json), --start-replay on browsers create and browser-pools create/update/acquire, and --locale / --clear-locale on auth connections create/update.
  • Product name. The two new 1Password status-check help strings say KERNEL, matching the rest of the vault help.

The retry behaviour of browsers create and pool acquire is unchanged.

Testing

  • TestBrowsersLiveViewCreateDoesNotRetry points a real client at a server returning 500 and asserts exactly one request; it fails without the option.
  • go build ./..., go vet ./..., and go test ./... pass.

Note

Medium Risk
Disabling retries on live-view create is security-relevant (orphan access URLs); remaining changes are docs and copy.

Overview
Follow-up to Go SDK v0.148.0 coverage: kernel browsers live-view create now calls the API with option.WithMaxRetries(0), since each request mints a non-revocable URL and a client retry after a lost response could leave an extra live URL the caller never sees (aligned with other one-shot mint commands). A regression test asserts a single HTTP attempt on 500.

README adds browsers live-view create (--scope, --ttl-seconds), --start-replay on browser create and browser-pool create/update/acquire, and --locale / --clear-locale on auth connection create/update.

Vault 1Password help text switches Kernel → KERNEL for consistency.

Reviewed by Cursor Bugbot for commit 41f936c. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant