Repository navigation
Follow up on Go SDK v0.148.0 coverage - #319
Open
masnwilliams wants to merge 2 commits into
Open
masnwilliams wants to merge 2 commits into
masnwilliams wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-ups to the Go SDK v0.148.0 coverage update.
browsers live-view create. Each call mints a live view URL that cannot be revoked, so a retry after a lost response could leave an extra live URL the caller never sees. The call now passesoption.WithMaxRetries(0), matchingbrowsers webmcp invokeanddeploy.browsers live-view create(--scope,--ttl-seconds,-o json),--start-replayonbrowsers createandbrowser-pools create/update/acquire, and--locale/--clear-localeonauth connections create/update.KERNEL, matching the rest of the vault help.The retry behaviour of
browsers createand pool acquire is unchanged.Testing
TestBrowsersLiveViewCreateDoesNotRetrypoints a real client at a server returning 500 and asserts exactly one request; it fails without the option.go build ./...,go vet ./..., andgo test ./...pass.Note
Medium Risk
Disabling retries on live-view create is security-relevant (orphan access URLs); remaining changes are docs and copy.
Overview
Follow-up to Go SDK v0.148.0 coverage:
kernel browsers live-view createnow calls the API withoption.WithMaxRetries(0), since each request mints a non-revocable URL and a client retry after a lost response could leave an extra live URL the caller never sees (aligned with other one-shot mint commands). A regression test asserts a single HTTP attempt on 500.README adds
browsers live-view create(--scope,--ttl-seconds),--start-replayon browser create and browser-pool create/update/acquire, and--locale/--clear-localeon auth connection create/update.Vault 1Password help text switches Kernel → KERNEL for consistency.
Reviewed by Cursor Bugbot for commit 41f936c. Bugbot is set up for automated code reviews on this repo. Configure here.