Skip to content

add archive reader - #60

Merged
katsyoshi merged 4 commits into
mainfrom
add-archive-support
Aug 24, 2026
Merged

add archive reader#60
katsyoshi merged 4 commits into
mainfrom
add-archive-support

Conversation

@katsyoshi

@katsyoshi katsyoshi commented Aug 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add an ar archive reader that parses archive headers and embedded ELF members.
  • Support GNU archive symbol tables and long filename tables.
  • Parse embedded ELF members lazily through StringIO.
  • Add archive inputs to the self linker and extract members that satisfy undefined global symbols.
  • Repeat archive extraction until no additional members are required, including transitive member dependencies.
  • Add archive fixture helpers and end-to-end coverage using compiled and assembled object files.

Testing

CI is currently broken, so this change was verified with the full test suite locally:

  • bundle exec rake test
    • 61 tests, 273 assertions, 0 failures, 0 errors, 1 omission
    • The omitted test requires Ruby::Box, which is not supported in the local environment.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d9ae2d540

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/caotral/binary/archive/reader.rb
Comment thread lib/caotral/binary/archive/reader.rb Outdated
@katsyoshi

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d9e7a1696f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/caotral/binary/archive/reader.rb Outdated
Comment thread lib/caotral/binary/archive/reader.rb Outdated
@katsyoshi

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 185a9317ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@katsyoshi
katsyoshi merged commit 7ca6559 into main Aug 24, 2026
0 of 2 checks passed
@katsyoshi
katsyoshi deleted the add-archive-support branch August 24, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant